refactor(@angular-devkit/build-angular): remove implicit localize polyfill #28507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
force-pushed
the
jk-mv-localize-polyfill
branch
from
557afe2 to
05a3b63
Compare
clydin
reviewed
Sep 26, 2024
packages/angular_devkit/build_angular/src/builders/karma/tests/options/exclude_spec.ts
Outdated
Show resolved
Hide resolved
…yfill In the v19 application builder, the localize polyfill should not be added implicitly. See: angular@d6a3403
jkrems
force-pushed
the
jk-mv-localize-polyfill
branch
from
05a3b63 to
ff4fda9
Compare
clydin
approved these changes
Sep 26, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the v19 application builder, the localize polyfill should not be added implicitly.
See: d6a3403
What Changes
./src/polyfills.tsin the base options so we have an easy way to inject the polyfill based on which builder is used.setupTargetfunction async so we can write to the polyfills file as part of the setup.